Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(winc for token): init getWincForToken PE-6632 #164

Merged
merged 8 commits into from
Sep 12, 2024

Conversation

fedellen
Copy link
Collaborator

No description provided.

@fedellen fedellen requested a review from a team as a code owner September 11, 2024 22:07
@fedellen fedellen self-assigned this Sep 11, 2024
@fedellen fedellen requested a review from dtfiedler September 11, 2024 22:07
@fedellen fedellen marked this pull request as draft September 11, 2024 22:20
@fedellen
Copy link
Collaborator Author

fedellen commented Sep 11, 2024

not yet passing CI. will continue tomorrow good to go!

@fedellen fedellen marked this pull request as ready for review September 12, 2024 14:44
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.35%. Comparing base (5870066) to head (bc930f4).
Report is 19 commits behind head on alpha.

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha     #164   +/-   ##
=======================================
  Coverage   92.35%   92.35%           
=======================================
  Files          30       30           
  Lines        3778     3778           
  Branches      164      164           
=======================================
  Hits         3489     3489           
  Misses        289      289           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fedellen fedellen force-pushed the PE-6632-get-winc-for-token branch from cc4f4d9 to 24852e9 Compare September 12, 2024 16:53
@fedellen fedellen force-pushed the PE-6632-get-winc-for-token branch from 24852e9 to 52c0eaa Compare September 12, 2024 17:02
src/types.ts Outdated
Comment on lines 110 to 111
// nativeAddress?: NativeAddress; TODO: Crypto promo code support on payment service
// promoCodes?: string[]; TODO: Crypto promo code support on payment service
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fedellen fedellen merged commit 06642e5 into alpha Sep 12, 2024
6 checks passed
@fedellen fedellen deleted the PE-6632-get-winc-for-token branch September 12, 2024 18:33
@dtfiedler
Copy link
Collaborator

🎉 This PR is included in version 1.16.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dtfiedler
Copy link
Collaborator

🎉 This PR is included in version 1.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants