Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onError and onEnd callbacks from mapAsyncIterator should be invoked only once #6677

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

enisdenjo
Copy link
Collaborator

No description provided.

@enisdenjo enisdenjo marked this pull request as ready for review November 13, 2024 14:17
Copy link

changeset-bot bot commented Nov 13, 2024

🦋 Changeset detected

Latest commit: 527bbf8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@graphql-tools/utils Patch
@graphql-tools/batch-delegate Patch
@graphql-tools/batch-execute Patch
@graphql-tools/delegate Patch
@graphql-tools/executor Patch
@graphql-tools/federation Patch
@graphql-tools/graphql-tag-pluck Patch
@graphql-tools/import Patch
@graphql-tools/links Patch
@graphql-tools/load Patch
@graphql-tools/merge Patch
@graphql-tools/mock Patch
@graphql-tools/node-require Patch
@graphql-tools/relay-operation-optimizer Patch
@graphql-tools/resolvers-composition Patch
@graphql-tools/schema Patch
@graphql-tools/stitch Patch
@graphql-tools/stitching-directives Patch
@graphql-tools/wrap Patch
@graphql-tools/apollo-engine-loader Patch
@graphql-tools/code-file-loader Patch
@graphql-tools/git-loader Patch
@graphql-tools/github-loader Patch
@graphql-tools/graphql-file-loader Patch
@graphql-tools/json-file-loader Patch
@graphql-tools/module-loader Patch
@graphql-tools/prisma-loader Patch
@graphql-tools/url-loader Patch
@graphql-tools/executor-apollo-link Patch
@graphql-tools/executor-envelop Patch
@graphql-tools/executor-graphql-ws Patch
@graphql-tools/executor-http Patch
@graphql-tools/executor-legacy-ws Patch
@graphql-tools/executor-urql-exchange Patch
@graphql-tools/executor-yoga Patch
federation-benchmark Patch
graphql-tools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@enisdenjo enisdenjo requested a review from ardatan November 13, 2024 14:17
Copy link
Contributor

github-actions bot commented Nov 13, 2024

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 330       ✗ 0  
     data_received..................: 38 MB   3.8 MB/s
     data_sent......................: 141 kB  14 kB/s
     http_req_blocked...............: avg=3.92µs   min=2.15µs   med=2.71µs   max=165.61µs p(90)=3.81µs   p(95)=4.01µs 
     http_req_connecting............: avg=677ns    min=0s       med=0s       max=111.8µs  p(90)=0s       p(95)=0s     
     http_req_duration..............: avg=56.12ms  min=47.16ms  med=52.52ms  max=161.03ms p(90)=62.9ms   p(95)=88.65ms
       { expected_response:true }...: avg=56.12ms  min=47.16ms  med=52.52ms  max=161.03ms p(90)=62.9ms   p(95)=88.65ms
     http_req_failed................: 0.00%   ✓ 0         ✗ 165
     http_req_receiving.............: avg=134.23µs min=103.94µs med=128.39µs max=530.56µs p(90)=146.82µs p(95)=153.9µs
     http_req_sending...............: avg=25.29µs  min=19.79µs  med=24.28µs  max=56.79µs  p(90)=32µs     p(95)=34.36µs
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s     
     http_req_waiting...............: avg=55.96ms  min=47.02ms  med=52.36ms  max=160.68ms p(90)=62.75ms  p(95)=88.48ms
     http_reqs......................: 165     16.469706/s
     iteration_duration.............: avg=60.69ms  min=51.18ms  med=56.78ms  max=165.3ms  p(90)=71.3ms   p(95)=92.45ms
     iterations.....................: 165     16.469706/s
     vus............................: 1       min=1       max=1
     vus_max........................: 1       min=1       max=1

@theguild-bot
Copy link
Collaborator

theguild-bot commented Nov 13, 2024

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-tools/batch-delegate 9.0.14-alpha-20241113142246-527bbf8c4e20af3d172439ab4746fe676b3a61c5 npm ↗︎ unpkg ↗︎
@graphql-tools/batch-execute 9.0.6-alpha-20241113142246-527bbf8c4e20af3d172439ab4746fe676b3a61c5 npm ↗︎ unpkg ↗︎
@graphql-tools/delegate 10.1.2-alpha-20241113142246-527bbf8c4e20af3d172439ab4746fe676b3a61c5 npm ↗︎ unpkg ↗︎
@graphql-tools/executor 1.3.3-alpha-20241113142246-527bbf8c4e20af3d172439ab4746fe676b3a61c5 npm ↗︎ unpkg ↗︎
@graphql-tools/executor-apollo-link 1.0.3-alpha-20241113142246-527bbf8c4e20af3d172439ab4746fe676b3a61c5 npm ↗︎ unpkg ↗︎
@graphql-tools/executor-envelop 3.0.11-alpha-20241113142246-527bbf8c4e20af3d172439ab4746fe676b3a61c5 npm ↗︎ unpkg ↗︎
@graphql-tools/executor-graphql-ws 1.3.2-alpha-20241113142246-527bbf8c4e20af3d172439ab4746fe676b3a61c5 npm ↗︎ unpkg ↗︎
@graphql-tools/executor-http 1.1.9-alpha-20241113142246-527bbf8c4e20af3d172439ab4746fe676b3a61c5 npm ↗︎ unpkg ↗︎
@graphql-tools/executor-legacy-ws 1.1.2-alpha-20241113142246-527bbf8c4e20af3d172439ab4746fe676b3a61c5 npm ↗︎ unpkg ↗︎
@graphql-tools/executor-urql-exchange 1.0.4-alpha-20241113142246-527bbf8c4e20af3d172439ab4746fe676b3a61c5 npm ↗︎ unpkg ↗︎
@graphql-tools/executor-yoga 3.0.11-alpha-20241113142246-527bbf8c4e20af3d172439ab4746fe676b3a61c5 npm ↗︎ unpkg ↗︎
@graphql-tools/federation 2.2.27-alpha-20241113142246-527bbf8c4e20af3d172439ab4746fe676b3a61c5 npm ↗︎ unpkg ↗︎
@graphql-tools/graphql-tag-pluck 8.3.4-alpha-20241113142246-527bbf8c4e20af3d172439ab4746fe676b3a61c5 npm ↗︎ unpkg ↗︎
graphql-tools 9.0.3-alpha-20241113142246-527bbf8c4e20af3d172439ab4746fe676b3a61c5 npm ↗︎ unpkg ↗︎
@graphql-tools/import 7.0.3-alpha-20241113142246-527bbf8c4e20af3d172439ab4746fe676b3a61c5 npm ↗︎ unpkg ↗︎
@graphql-tools/links 9.0.12-alpha-20241113142246-527bbf8c4e20af3d172439ab4746fe676b3a61c5 npm ↗︎ unpkg ↗︎
@graphql-tools/load 8.0.4-alpha-20241113142246-527bbf8c4e20af3d172439ab4746fe676b3a61c5 npm ↗︎ unpkg ↗︎
@graphql-tools/apollo-engine-loader 8.0.4-alpha-20241113142246-527bbf8c4e20af3d172439ab4746fe676b3a61c5 npm ↗︎ unpkg ↗︎
@graphql-tools/code-file-loader 8.1.5-alpha-20241113142246-527bbf8c4e20af3d172439ab4746fe676b3a61c5 npm ↗︎ unpkg ↗︎
@graphql-tools/git-loader 8.0.9-alpha-20241113142246-527bbf8c4e20af3d172439ab4746fe676b3a61c5 npm ↗︎ unpkg ↗︎
@graphql-tools/github-loader 8.0.4-alpha-20241113142246-527bbf8c4e20af3d172439ab4746fe676b3a61c5 npm ↗︎ unpkg ↗︎
@graphql-tools/graphql-file-loader 8.0.3-alpha-20241113142246-527bbf8c4e20af3d172439ab4746fe676b3a61c5 npm ↗︎ unpkg ↗︎
@graphql-tools/json-file-loader 8.0.3-alpha-20241113142246-527bbf8c4e20af3d172439ab4746fe676b3a61c5 npm ↗︎ unpkg ↗︎
@graphql-tools/module-loader 8.0.3-alpha-20241113142246-527bbf8c4e20af3d172439ab4746fe676b3a61c5 npm ↗︎ unpkg ↗︎
@graphql-tools/prisma-loader 8.0.17-alpha-20241113142246-527bbf8c4e20af3d172439ab4746fe676b3a61c5 npm ↗︎ unpkg ↗︎
@graphql-tools/url-loader 8.0.15-alpha-20241113142246-527bbf8c4e20af3d172439ab4746fe676b3a61c5 npm ↗︎ unpkg ↗︎
@graphql-tools/merge 9.0.9-alpha-20241113142246-527bbf8c4e20af3d172439ab4746fe676b3a61c5 npm ↗︎ unpkg ↗︎
@graphql-tools/mock 9.0.6-alpha-20241113142246-527bbf8c4e20af3d172439ab4746fe676b3a61c5 npm ↗︎ unpkg ↗︎
@graphql-tools/node-require 7.0.4-alpha-20241113142246-527bbf8c4e20af3d172439ab4746fe676b3a61c5 npm ↗︎ unpkg ↗︎
@graphql-tools/relay-operation-optimizer 7.0.3-alpha-20241113142246-527bbf8c4e20af3d172439ab4746fe676b3a61c5 npm ↗︎ unpkg ↗︎
@graphql-tools/resolvers-composition 7.0.3-alpha-20241113142246-527bbf8c4e20af3d172439ab4746fe676b3a61c5 npm ↗︎ unpkg ↗︎
@graphql-tools/schema 10.0.8-alpha-20241113142246-527bbf8c4e20af3d172439ab4746fe676b3a61c5 npm ↗︎ unpkg ↗︎
@graphql-tools/stitch 9.3.4-alpha-20241113142246-527bbf8c4e20af3d172439ab4746fe676b3a61c5 npm ↗︎ unpkg ↗︎
@graphql-tools/stitching-directives 3.1.13-alpha-20241113142246-527bbf8c4e20af3d172439ab4746fe676b3a61c5 npm ↗︎ unpkg ↗︎
@graphql-tools/utils 10.5.6-alpha-20241113142246-527bbf8c4e20af3d172439ab4746fe676b3a61c5 npm ↗︎ unpkg ↗︎
@graphql-tools/wrap 10.0.16-alpha-20241113142246-527bbf8c4e20af3d172439ab4746fe676b3a61c5 npm ↗︎ unpkg ↗︎

Copy link
Contributor

github-actions bot commented Nov 13, 2024

💻 Website Preview

The latest changes are available as preview in: https://2730e1d9.graphql-tools.pages.dev

@enisdenjo enisdenjo merged commit dc5043b into master Nov 13, 2024
29 checks passed
@enisdenjo enisdenjo deleted the onend-once branch November 13, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants