allow toString directive (check isNode on merge if inherited from prototype) #5973
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.
Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of
the pull request.
Description
I was trying to make a toString directive and makeExecutableSchema was failing.
It wasn't working because it creates an object (mergedResultMap in function mergeGraphQLNodes) and objects have an inherited toString method. So it was finding that toString exists in the map because it was the inherited object function, not a directive. (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/hasOwnProperty#direct_vs._inherited_properties)
So I thought maybe when merging the directive it could check if it exists and if it's an inherited property and not a node, then set to undefined so it can proceed to create the directive node instead of the inherited object function.
Related #5967
Type of change
Please delete options that are not relevant.
Screenshots/Sandbox (if appropriate/relevant):
Codesandbox to show the error https://codesandbox.io/p/devbox/brave-visvesvaraya-49xx8m
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can
reproduce. Please also list any relevant details for your test configuration
Test Environment:
@graphql-tools/...
:Checklist:
CONTRIBUTING doc and the
style guidelines of this project
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose
the solution you did and what alternatives you considered, etc...