-
-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test case mergetypedefs overriding existing fields #5075
Test case mergetypedefs overriding existing fields #5075
Conversation
🦋 Changeset detectedLatest commit: 93cfe4a The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@graphql-tools/stitching-directives", | |||
"version": "2.3.30", | |||
"version": "2.3.31", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you fix these unrelated diffs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am sorry I am not sure what I should do, I never did this before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry about that, had a collegue help out, it should be ok now, let me know
13c063b
to
eb0f283
Compare
Thank you! Could you create a changeset by using |
Is this ok? Summary · Added onFieldTypeConflict option to handle manual conflicts for mergeTypeDef and reverseArguments option to select left side arguments if specified. === Summary of changesets === If yes, I will proceed! |
@simplecommerce Looks good to me! Thanks 🙏 |
you did most of the job, thank you! |
🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.
Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.
Description
These are only test cases to demonstrate a desired feature.
To have the ability to override existing fields for Types and Inputs when using
mergeTypeDefs
.In my current project, I am using
mergeTypeDefs
in order to allow to customize existing schemas without applying modifications directly to our core.Related # (issue)
Type of change
Please delete options that are not relevant.
Screenshots/Sandbox (if appropriate/relevant):
Adding links to sandbox or providing screenshots can help us understand more about this PR and take action on it as appropriate
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Environment:
@graphql-tools/...
:Checklist: