Skip to content

Commit

Permalink
Faster CI
Browse files Browse the repository at this point in the history
  • Loading branch information
ardatan committed Nov 22, 2024
1 parent 414e404 commit def796f
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 12 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
with:
npmTag: alpha
buildScript: build
nodeVersion: 18
nodeVersion: 22
secrets:
githubToken: ${{ secrets.GUILD_BOT_TOKEN }}
npmToken: ${{ secrets.NODE_AUTH_TOKEN }}
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
uses: the-guild-org/shared-config/.github/workflows/release-stable.yml@main
with:
releaseScript: release
nodeVersion: 18
nodeVersion: 22
secrets:
githubToken: ${{ secrets.GUILD_BOT_TOKEN }}
npmToken: ${{ secrets.NODE_AUTH_TOKEN }}
11 changes: 3 additions & 8 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,11 @@ jobs:
- name: Setup env
uses: the-guild-org/shared-config/setup@main
with:
nodeVersion: 18
nodeVersion: 22

- name: Prettier Check
run: yarn prettier:check
lint:
needs: [prettier-check]
name: Lint
uses: the-guild-org/shared-config/.github/workflows/lint.yml@main
with:
Expand All @@ -36,7 +35,6 @@ jobs:
githubToken: ${{ secrets.GITHUB_TOKEN }}

build:
needs: [lint]
name: Type Check on GraphQL v${{matrix.graphql_version}}
runs-on: ubuntu-latest
strategy:
Expand All @@ -52,7 +50,7 @@ jobs:
- name: Setup env
uses: the-guild-org/shared-config/setup@main
with:
nodeVersion: 18
nodeVersion: 22

- name: Use GraphQL v${{matrix.graphql_version}}
run: node ./scripts/match-graphql.js ${{matrix.graphql_version}}
Expand All @@ -61,7 +59,6 @@ jobs:
- name: Type Check
run: yarn ts:check
test_esm:
needs: [build]
name: ESM Test
runs-on: ubuntu-latest
steps:
Expand All @@ -71,14 +68,13 @@ jobs:
- name: Setup env
uses: the-guild-org/shared-config/setup@main
with:
nodeVersion: 18
nodeVersion: 22

- name: Build Packages
run: yarn build
- name: Test ESM and CJS integrity
run: yarn bob check
test:
needs: [test_esm]
name:
Unit Test on Node ${{matrix.node-version}} (${{matrix.os}}) and GraphQL
v${{matrix.graphql_version}}
Expand Down Expand Up @@ -129,7 +125,6 @@ jobs:
command: yarn test:leaks --ci

test_browser:
needs: [test]
name: Browser Test
runs-on: ubuntu-latest
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/website.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
- uses: the-guild-org/shared-config/setup@main
name: setup env
with:
nodeVersion: 18
nodeVersion: 22
packageManager: yarn

- uses: the-guild-org/shared-config/website-cf@main
Expand Down
2 changes: 1 addition & 1 deletion packages/utils/src/map-maybe-promise.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { isPromise } from '../src/jsutils.js';
import { MaybePromise } from './executor.js';
import { isPromise } from './jsutils.js';

export function mapMaybePromise<T, R>(
value: MaybePromise<T>,
Expand Down

0 comments on commit def796f

Please sign in to comment.