Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script for SQL Local DB setup. #357

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Conversation

fiseni
Copy link
Collaborator

@fiseni fiseni commented Aug 4, 2023

The Local DB comes pre-installed for Windows hosts, but our tests are occasionally failing to establish a connection. Adding an explicit task might ensure the DB is up and ready before it continues with the next job. At least I think so :) Let's try it.

@fiseni fiseni requested a review from ardalis August 4, 2023 14:30
@fiseni
Copy link
Collaborator Author

fiseni commented Aug 4, 2023

It seems it fixed the issue.
Btw, we'll have to update and improve the fixtures for our infrastructure tests, but I'll do that in a separate PR.

@ardalis ardalis merged commit 13e71bb into main Aug 4, 2023
@fiseni fiseni mentioned this pull request Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants