Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

committing ru.ts #14

Merged
merged 2 commits into from
Apr 4, 2021
Merged

committing ru.ts #14

merged 2 commits into from
Apr 4, 2021

Conversation

TombOfVARN
Copy link
Contributor

My first pull request ever, figured I might as well learn how to do it.
Commiting ru.ts. Cards are in progress. I felt that terminology is more or less solid now (changed a few times because some card texts just don't make sense with certain terminology), so there is less chance I'd have to redo ru.ts now, even though it is still possible.

resource: 'resource',
tower: 'Башня',
wall: 'Стена',
resource: 'Ресурс', // where is this used? couldn't find
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's in the "Preferences" settings (click the gear icon)

'Victory Conditions': 'Условия победы',
'Other Preferences': 'Другие настройки',
'Cards in Hand': 'Карт в руке',
'AI Type': 'Тип ИИ', // couldn't find ingame
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's currently not in the game but planned in the future

'Other Preferences': 'Другие настройки',
'Cards in Hand': 'Карт в руке',
'AI Type': 'Тип ИИ', // couldn't find ingame
'Apply & New Game': 'Применить и начать игру', // 7 symbols longer, may want to use just "Начать игру!" instead if the button doesn't stretch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The button here's flexible. Don't worry

Help: 'Помощь',
'Toggle Full Screen': 'Полноэкранный режим',

ERATHIAN: 'Использовать Эрафийский [%s] (только для латиницы)', //probably not needed in RU locale at all
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually needed in all langs, espacially in non-latin-based langs because it serves as a notification for non latin


ERATHIAN: 'Использовать Эрафийский [%s] (только для латиницы)', //probably not needed in RU locale at all

'ArcoMage HD': 'Аркомаг HD', // "Аркомаг" name is well known in Russia in its RU version, since just like Gwent (known in Russia as Гвинт), it was first introduced as a minigame inside another game, so they had to translate the name
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK


'Below is a brief presentation of the rules:':
'Below is a brief presentation of the rules:',
'Правила игры:', // because full is too long here "Ниже вы можете найти краткое изложение правил:", and pretty pointless too, might even want to shorten it in source lang
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll change the English text. Actually I might change all these to an image or even an interactive tour guide.

@tomchen tomchen merged commit 4315c4d into arcomage:main Apr 4, 2021
@tomchen
Copy link
Member

tomchen commented Apr 4, 2021

Thank you very much. Nice work. I've merged the PR

@tomchen
Copy link
Member

tomchen commented Apr 4, 2021

There are two strings added today. Please translate them or just correct the machine translated ones:

  • With no usable or discardable card, your opponent has surrendered
  • Не имея пригодной для использования или сбрасываемой карты, ваш оппонент сдался.
  • With no usable or discardable card, you have surrendered
  • Не имея удобной для использования или сбрасываемой карты, вы сдались.

tomchen added a commit that referenced this pull request Apr 4, 2021
@TombOfVARN
Copy link
Contributor Author

Is it even possible to achieve such state in Arcomage? Full hand of Lodestones? LOL
Idk, maybe better give player a new hand in such case? The chance is really miniscule anyway.

With no usable or discardable card, your opponent has surrendered
Если у противника нет возможности ни сыграть, ни сбросить карту, он автоматически сдается
With no usable or discardable card, you have surrendered
Если у вас нет возможности ни сыграть, ни сбросить карту, вы автоматически сдаетесь

@tomchen
Copy link
Member

tomchen commented Apr 5, 2021

In the card data file every card has a property prob that represents its probability of being dealed. People with the source code could change Lodestones' prob and rebuild the game. It's not for normal players who do not code though.

However, players could indeed do one thing: in the "Preferences", set "Cards in Hand" to 0 or 1, where an all-Lodestones situation is pretty likely

@tomchen
Copy link
Member

tomchen commented Apr 5, 2021

I don't speak Spanish but have just finished checking the cards in Spanish.

I remember you said these RU translations are not very good so you're gonna retranslate or something?:
https://github.com/arcomage/arcomage-hd/blob/main/tools/ocr/original/ru.png
https://github.com/arcomage/arcomage-hd/blob/main/tools/ocr/original/ru7.png
I don't know, but if they are readable, you can use or partially use them. Checking & comparing to the image would be quicker than retranslating (or maybe machine translate https://www.deepl.com/translator / https://translate.google.com/ then check them, that'd be quick too)

@TombOfVARN
Copy link
Contributor Author

TombOfVARN commented Apr 5, 2021

ru7 link is new to me. And useful. It seems to be overall of higher quality compared to 8. Some of the decisions here are the same I made, and some are different, yet good. The possibility I will resend ru.ts also increased slighly.

It's not like the one in 8 is unusable, it is just of low quality. Player will still be able to understand it and play with it, it's just a bit cringey and there is no system in the way stuff is translated. mm7 one seems to have a system alright, it's good.

Also, there are some fact mistakes in MM8 one. Like in rules it says you use Magic to play blue cards, instead of Gems.

tomchen added a commit that referenced this pull request Apr 5, 2021
@tomchen
Copy link
Member

tomchen commented Apr 5, 2021

Card translation files are in src/i18n/cards/ folder and in use now. The incomplete languages are using English text as placeholder.

When you finish the cards in RU, edit or open a pull request on this file:
https://github.com/arcomage/arcomage-hd/blob/main/src/i18n/cards/ru.ts

@tomchen tomchen mentioned this pull request Apr 6, 2021
@tomchen tomchen added i18n Internationalization and localization / translation medium priority Medium priority labels Apr 18, 2021
@tomchen tomchen linked an issue Apr 22, 2021 that may be closed by this pull request
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Internationalization and localization / translation medium priority Medium priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[META] I18N (Translation / Localization)
2 participants