Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates the library to use the apache httpclient5-fluent library for … #4

Merged
merged 1 commit into from
May 22, 2023

Conversation

jacomago
Copy link
Contributor

…http requests.

Main advantage is support for accepting gzipped data, which can be configured in the retrieval tomcat of the archiver appliance.

Also update the protobuf library to the latest one and auto regenerates the java code on build.

…http requests.

Main advantage is support for accepting gzipped data, which can be configured in the retrieval tomcat of the
archiver appliance.

Also update the protobuf library to the latest one and auto regenerates the java code on build.
@jacomago jacomago force-pushed the gzip_and_protobuf branch from bb875bb to 1d86777 Compare May 22, 2023 07:19
@slacmshankar slacmshankar merged commit 0e231f1 into archiver-appliance:master May 22, 2023
@jacomago jacomago deleted the gzip_and_protobuf branch May 22, 2023 15:29
@shroffk
Copy link
Contributor

shroffk commented May 23, 2023

Thanks for this update, we can surely get this hosted on maven.

In the .proto file, I see that it is identical to the previous one ( same default as supported by proto2 ).. but the explicit setting of the syntax to "proto2" was removed. I am guessing this will have no impact on existing deployments.
We (@georgweiss) recently upgraded the client to use 3.21.9 , which version is this using ( sorry about my ignorance on gradle dependency management )

Did we need to move the test resources from src/test to lib/src/test to comply with gradle standards? With the build.xml removed... will future builds only be supported with gradle.

Sorry for these questions.

@jacomago
Copy link
Contributor Author

Ah, didn't mean to remove the syntax line. Have made another pull request, I was copying from the archiver version of the file. I don't think it makes a difference as the protobuf compiler defaults to syntax "proto2".

The protobuf library is 'com.google.protobuf:protobuf-java:3.23.0'.

I moved the test resouces to follow gradle/maven standards.

I removed the build.xml to focus on gradle, I thought it might be easiser to use. There is a maven repository plugin https://docs.gradle.org/current/userguide/publishing_maven.html which should make it easier to get it hosted.

slacmshankar pushed a commit that referenced this pull request Jan 10, 2024
* Add publish workflow to github

* update build action version

* add gradle publish plugin and settings
slacmshankar added a commit that referenced this pull request Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants