Improve DX for shared TS codebase #4
Conversation
|
|
|
Thanks! Although this PR doesn’t address what we discussed in the issue, which is to recompile tsconfig paths. We should not assume src/shared is significant to TS users. |
The code section is only recompiling typescript handlers if the file ends with |
|
It will work for some, but this is more along the lines of the Architecty way, not the TypeScripty way. The approach we've tried to take for this plugin was to build it in the most TypeScripty way possible. In the example app we demonstrate using both If we are going to look at |
|
@ryanblock I've updated the logic to use tsconfig.json |
src/shared| return | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This looks good otherwise, although we still need tests!
There was a problem hiding this comment.
@ryanblock I've updated the logic to:
- take care of windows path
- take care of non TS/TSX paths alias
|
|
||
| let enPath = join(mock, 'defaults', 'src', 'shared', 'locales', 'en.ts') | ||
| let oldEn = readFileSync(enPath) | ||
| writeFileSync(enPath, 'export default "bar";\n') |
There was a problem hiding this comment.
@ryanblock Is there a way to start the sandbox with watcher? It seems like we can only start sandbox with watcher using CLI...
Thank you for helping out! ✨
We really appreciate your commitment to improving Architect
To maintain a high standard of quality in our releases, before merging every pull request we ask that you've completed the following:
masternpm itfrom the repo root)readme.md, help docs, inline docs & comments, etc.)changelog.mdPlease also be sure to completed the CLA (if you haven't already).
Learn more about contributing to Architect here.
Thanks again!