Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Declare external api types #502

Closed
wants to merge 3 commits into from
Closed

Conversation

tbeseda
Copy link
Member

@tbeseda tbeseda commented Sep 22, 2021

🚧 These aren't up to date and many are just stubs right now.

Original reference: https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/architect__functions

notes

existing JSDoc annotations do not bubble up because factory design patterns
could move/copy JSDoc comments to main index
handwrite .d.ts file
automate type extractions?

found:


## Thank you for helping out! ✨

We really appreciate your commitment to improving Architect

To maintain a high standard of quality in our releases, before merging every pull request we ask that you've completed the following:

  • Forked the repo and created your branch from master
  • Made sure tests pass (run npm it from the repo root)
  • Expanded test coverage related to your changes:
    • Added and/or updated unit tests (if appropriate)
    • Added and/or updated integration tests (if appropriate)
  • Updated relevant documentation:
  • Summarized your changes in changelog.md
  • Linked to any related issues, PRs, etc. below that may relate to, consume, or necessitate these changes

Please also be sure to completed the CLA (if you haven't already).

Learn more about contributing to Architect here.

Thanks again!

@tbeseda
Copy link
Member Author

tbeseda commented Nov 22, 2021

Closing in favor of maintaining types in Definitely Typed
WIP: DefinitelyTyped/DefinitelyTyped#57323

@tbeseda tbeseda closed this Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant