WIP: CameraX #3
Open
WIP: CameraX #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arka Prava Basu <arkaprava94@gmail.com>
- due to camerax preview lib we need to make minSDK to 21 from 16; if this is going to be a major problem we may need to go ahead without the preview lib Signed-off-by: Arka Prava Basu <arkaprava94@gmail.com>
Signed-off-by: Arka Prava Basu <arkaprava94@gmail.com>
Signed-off-by: Arka Prava Basu <arkaprava94@gmail.com>
- Use PreviewView instead of CameraView - MotionAnalyser as the image analysis Use Case to work with MotionDetector to detct motion - save image on motion detect and notify running service - Expose LiveData from MotionDetector for result; alternative to callbacks Signed-off-by: Arka Prava Basu <arkaprava94@gmail.com>
Signed-off-by: Arka Prava Basu <arkaprava94@gmail.com>
Signed-off-by: Arka Prava Basu <arkaprava94@gmail.com>
- current implementation does not allow both image and video capture simultaneously Signed-off-by: Arka Prava Basu <arkaprava94@gmail.com>
Signed-off-by: Arka Prava Basu <arkaprava94@gmail.com>
- stop monitoring via a message to service instead of invoking from outside - close the activity after a delay of 3s to clean up video capture and image capture Signed-off-by: Arka Prava Basu <arkaprava94@gmail.com>
Signed-off-by: Arka Prava Basu <arkaprava94@gmail.com>
Signed-off-by: Arka Prava Basu <arkaprava94@gmail.com>
- listen on a live data of result instead of events - string formatting Signed-off-by: Arka Prava Basu <arkaprava94@gmail.com>
Signed-off-by: Arka Prava Basu <arkaprava94@gmail.com>
Signed-off-by: Arka Prava Basu <arkaprava94@gmail.com>
Signed-off-by: Arka Prava Basu <arkaprava94@gmail.com>
- Keep switch in preference to toggle simultaneous video monitoring - when on along with video monitoring both image and video will be captured; this will stop camera preview - when off but video monitoring on only video will be captured for the camera events and we will have image preview - video monitoring off will keep only image capture on Signed-off-by: Arka Prava Basu <arkaprava94@gmail.com>
- Copy image helper from cameraview lib Signed-off-by: Arka Prava Basu <arkaprava94@gmail.com>
Signed-off-by: Arka Prava Basu <arkaprava94@gmail.com> Update dependencies Signed-off-by: Arka Prava Basu <arkaprava94@gmail.com>
Signed-off-by: Arka Prava Basu <arkaprava94@gmail.com>
Signed-off-by: Arka Prava Basu <arkaprava94@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully will resolve guardianproject#360