refactor: ♻️ Rename Tx serialization for blockchain node.

archethic-foundation · Dec 10, 2024 · 2d3d7e9 · 2d3d7e9
1 parent 33ea5f8
commit 2d3d7e9
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 12 deletions.
diff --git a/example/example.dart b/example/example.dart
@@ -21,7 +21,7 @@ void main(List<String> args) {
       )
       .build('mysuperpassphraseorseed', 0, curve: 'P256')
       .transaction
-    ..convertToJSON();
+    ..toNodeRPC();
 
   /// Sign the transaction with an origin device private key
   final originKeypair = deriveKeyPair('origin_seed', 0, isSeedHexa: false);
@@ -39,7 +39,7 @@ void main(List<String> args) {
         uint8ListToHex(
           Uint8List.fromList(originKeypair.privateKey!),
         ),
-      )..convertToJSON();
+      )..toNodeRPC();
 
   /// Export the transaction generated into JSON
   final transaction3 = Transaction(
@@ -52,5 +52,5 @@ void main(List<String> args) {
       )
       .build('mysuperpassphraseorseed', 0, curve: 'P256')
       .transaction
-    ..convertToJSON();
+    ..toNodeRPC();
 }
diff --git a/lib/src/model/transaction.dart b/lib/src/model/transaction.dart
@@ -495,7 +495,7 @@ class Transaction with _$Transaction {
   }
 
   /// Convert the transaction in JSON
-  String convertToJSON() {
+  String toNodeRPC() {
     final json = jsonEncode(<String, Object?>{
       'version': version,
       'address': address == null ? '' : address!.address,

diff --git a/lib/src/services/api_service.dart b/lib/src/services/api_service.dart
@@ -74,7 +74,7 @@ class ApiService with JsonRPCUtil {
         'send_transaction',
         {
           'transaction': jsonDecode(
-            transaction.convertToJSON(),
+            transaction.toNodeRPC(),
           ),
         },
       );
@@ -495,7 +495,7 @@ class ApiService with JsonRPCUtil {
       'estimate_transaction_fee',
       {
         'transaction': jsonDecode(
-          transaction.convertToJSON(),
+          transaction.toNodeRPC(),
         ),
       },
     );

diff --git a/test/keychain_test.dart b/test/keychain_test.dart
@@ -206,7 +206,7 @@ void main() {
             derivationPath: kDerivationPath,
           );
           dev.log(
-            'keychainTransaction: ${keychainTransaction.convertToJSON()}',
+            'keychainTransaction: ${keychainTransaction.toNodeRPC()}',
           );
 
           /// Create Keychain Access for wallet
@@ -219,7 +219,7 @@ void main() {
             Uint8List.fromList(hexToUint8List(originPrivateKey)),
             blockchainTxVersion,
           );
-          dev.log('accessKeychainTx: ${accessKeychainTx.convertToJSON()}');
+          dev.log('accessKeychainTx: ${accessKeychainTx.toNodeRPC()}');
 
           // ignore: unused_local_variable
           final transactionStatusKeychain =
@@ -361,7 +361,7 @@ void main() {
             derivationPath: kDerivationPath,
           );
           dev.log(
-            'keychainTransaction: ${keychainTransaction.convertToJSON()}',
+            'keychainTransaction: ${keychainTransaction.toNodeRPC()}',
           );
 
           /// Create Keychain Access for wallet
@@ -374,7 +374,7 @@ void main() {
             Uint8List.fromList(hexToUint8List(originPrivateKey)),
             blockchainTxVersion,
           );
-          dev.log('accessKeychainTx: ${accessKeychainTx.convertToJSON()}');
+          dev.log('accessKeychainTx: ${accessKeychainTx.toNodeRPC()}');
 
           // ignore: unused_local_variable
           final transactionStatusKeychain =

diff --git a/test/transaction_test.dart b/test/transaction_test.dart
@@ -51,7 +51,7 @@ void main() {
                 ])
             .build('seed', 0, curve: 'P256', isSeedHexa: false)
             .transaction;
-        final dynamic parsedTx = json.decode(tx.convertToJSON());
+        final dynamic parsedTx = json.decode(tx.toNodeRPC());
         expect(
             parsedTx['data']['ownerships'][0]['authorizedKeys'],
             <Map<String, String>>[
@@ -693,7 +693,7 @@ condition inherit: [
               uint8ListToHex(Uint8List.fromList(originKeypair.privateKey!)),
             );
 
-        final Map<String, dynamic> parsedTx = json.decode(tx.convertToJSON());
+        final Map<String, dynamic> parsedTx = json.decode(tx.toNodeRPC());
 
         final previousSig = crypto.sign(
           tx.previousSignaturePayload(),