Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 🔒 Upgrade android targetSdkVersion #1027

Conversation

redDwarf03
Copy link
Member

Description

Fixes #1025

Material used:

Please delete options that are not relevant.

  • Android (Smartphone/Tablet)

How Has This Been Tested?

Manual tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Useful info for the reviewer:

@redDwarf03 redDwarf03 linked an issue Jul 9, 2024 that may be closed by this pull request
@redDwarf03
Copy link
Member Author

Tests ok with Pixel 5 API 34, except

  • NFT creation with web link
  • fungible token sending
  • aeSwap webview

@redDwarf03 redDwarf03 marked this pull request as draft July 9, 2024 20:19
@redDwarf03 redDwarf03 requested a review from Chralu July 10, 2024 08:35
@redDwarf03 redDwarf03 marked this pull request as ready for review July 10, 2024 08:36
@Chralu
Copy link
Collaborator

Chralu commented Jul 11, 2024

Globally OK to me.

There is one strange behavior in picture selection process : when using the "browser" button, selected picture is not taken into account by the application.

picture_select.mp4

@redDwarf03 redDwarf03 merged commit f55440a into dev Jul 11, 2024
3 checks passed
@redDwarf03 redDwarf03 deleted the 1025-niveau-dapi-cible-non-conforme-le-plus-élevé-est-android-13 branch July 11, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Niveau d'API cible non conforme le plus élevé est Android 13
2 participants