Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure code proposal contains a valid appup file with the right versions #899

Merged

Conversation

tenmoves
Copy link
Contributor

@tenmoves tenmoves commented Feb 8, 2023

Description

In the current version, code proposals are built from text/plain style:

Description: ......
Changes:
{git diff}
However, to be complete and to avoid unexpected results during the upgrade, we should require the appup instructions to be present.
Hence, we could check the impact of the code proposals and the proposal's correctness.

Fixes #873

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@tenmoves tenmoves added core team Assigned to the core team Governance About On-Chain governance labels Feb 8, 2023
@tenmoves tenmoves self-assigned this Feb 8, 2023
Copy link
Member

@samuelmanzanera samuelmanzanera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.
Seems great 👍

I put some remarks, I would have to test it in the meantime.

lib/archethic/governance/code.ex Outdated Show resolved Hide resolved
test/archethic/governance/code_test.exs Outdated Show resolved Hide resolved
@tenmoves tenmoves force-pushed the ensure_appup_is_present branch from 886726f to 239c59d Compare February 14, 2023 16:12
Copy link
Contributor

@bchamagne bchamagne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to create a code proposal without and with appup and it failed and worked as expected:

Screenshot 2023-02-22 at 18-17-22 ARCHETHIC

@samuelmanzanera samuelmanzanera merged commit 10478dd into archethic-foundation:develop Feb 22, 2023
@samuelmanzanera samuelmanzanera added the feature New feature request label May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core team Assigned to the core team feature New feature request Governance About On-Chain governance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure each code proposal includes appup
3 participants