Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve release #890

Merged

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Feb 6, 2023

Description

Improve script test-release.sh to create 2 releases folder so we can run 2 nodes at the same time and launch the release on both.

Also refactor the messageId module, so distillery can correctly import the dependencies.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Update a version where some dependencies of Message module are update (Ping message for example).
Generate the appup using distillery.gen.appup, the generated appup has the Message module has the Ping module in dependency.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@samuelmanzanera samuelmanzanera merged commit 319b8e5 into archethic-foundation:develop Feb 8, 2023
@Neylix Neylix deleted the Improve-release branch February 28, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants