Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Test Crahes/Warnings #2 #884

Merged
merged 6 commits into from
Feb 8, 2023
Merged

Fix Test Crahes/Warnings #2 #884

merged 6 commits into from
Feb 8, 2023

Conversation

apoorv-2204
Copy link
Contributor

No description provided.

@apoorv-2204 apoorv-2204 requested review from samuelmanzanera, Neylix and bchamagne and removed request for samuelmanzanera and Neylix February 2, 2023 07:41
@apoorv-2204 apoorv-2204 self-assigned this Feb 2, 2023
@apoorv-2204 apoorv-2204 added quality Improve code quality testing Improve testing labels Feb 2, 2023
@Neylix
Copy link
Member

Neylix commented Feb 2, 2023

Awesome !
That will be so nice do not have so much error log during the test, well done !
I still have 2 errors (appearing almost all the time)
image
image

@apoorv-2204 apoorv-2204 requested a review from tenmoves February 2, 2023 14:35
@apoorv-2204 apoorv-2204 marked this pull request as ready for review February 2, 2023 15:06
@apoorv-2204 apoorv-2204 requested a review from netboz February 2, 2023 15:07
Neylix
Neylix requested changes Feb 2, 2023
View reviewed changes
test/archethic/bootstrap_test.exs Outdated Show resolved Hide resolved
@apoorv-2204 apoorv-2204 requested a review from Neylix February 2, 2023 17:11
@apoorv-2204 apoorv-2204 requested a review from Neylix February 3, 2023 12:49
samuelmanzanera
samuelmanzanera reviewed Feb 6, 2023
View reviewed changes
Copy link
Member

@samuelmanzanera samuelmanzanera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also saw on the GIthub Actions logs some error or warning regarding mem tables and TransactionSubscriber

@apoorv-2204
Copy link
Contributor Author

I also saw on the GIthub Actions logs some error or warning regarding mem tables and TransactionSubscriber

For that I have dropped async test, we have to rethink about test designs. To make test async

@samuelmanzanera
Copy link
Member

I still got some issues in the tests for graphql_tests

image

Also the graphql tests are really slow (~4s)

@apoorv-2204
Copy link
Contributor Author

I still got some issues in the tests for graphql_tests

image

Also the graphql tests are really slow (~4s)

Drop build and retry.
We can have an another pr for it, as so many other issues are still remaining with tests

@samuelmanzanera
Copy link
Member

I think it's my conf. No worry

@apoorv-2204
Copy link
Contributor Author

apoorv-2204 commented Feb 8, 2023 •
edited
Loading

I think it's my conf. No worry

ok BOSS

@samuelmanzanera
Copy link
Member

I think it's my conf. No worry

ok BOSS

Can you fix the conflicts before merge ?

apoorv-2204 and others added 3 commits February 8, 2023 19:38
@apoorv-2204
Resolve Test Crashes, beacon_chain, validation
16cc16e
@apoorv-2204
Convert MockCrypto to specific Mocks
435a68f
@apoorv-2204 @Neylix
Make Test deterministic
9bc9af9 
  Bootstrap - Remove unused supervisor,
  BeaconTest - allow mocks for NewBeaconSlot

Co-authored-by: Julien <julien@uniris.io>
@apoorv-2204
Copy link
Contributor Author

I think it's my conf. No worry

ok BOSS

Can you fix the conflicts before merge ?

Done

@samuelmanzanera samuelmanzanera merged commit f9be67c into archethic-foundation:develop Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bchamagne bchamagne Awaiting requested review from bchamagne

@tenmoves tenmoves Awaiting requested review from tenmoves

@netboz netboz Awaiting requested review from netboz

@Neylix Neylix Awaiting requested review from Neylix

@samuelmanzanera samuelmanzanera Awaiting requested review from samuelmanzanera

Assignees

@apoorv-2204 apoorv-2204

Labels
quality Improve code quality testing Improve testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apoorv-2204 @Neylix @samuelmanzanera