-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display the size when listing the files of a directory #807
Display the size when listing the files of a directory #807
Conversation
@@ -116,6 +116,7 @@ | |||
<thead> | |||
<tr> | |||
<th>Name</th> | |||
<th class="size">Size(Bytes)</th> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to define the css class called size.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will update that. No problem with it. Please tell me how to view the below screen in localhost.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hello, you can follow this doc #800 (comment) to view the screen
@@ -147,6 +148,7 @@ | |||
</tbody> | |||
</table> | |||
</td> | |||
<td class="size"><%= file.size %></td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same "size" css class isn't defined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I know, but i am asking you how to view this indexof screen in localhost.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also file.size will not work because we don't provide this field in lib/archethic_web/controllers/api/web_hosting_controller/directory_listing.ex
@tarunsamanta2k20 , any update on this? |
@bchamagne |
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #800
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
with internal dir
![image](https://user-images.githubusercontent.com/11648790/214279993-10167b38-fe8a-4118-b5cd-f271e69eaaf0.png)
Checklist:
@tarunsamanta2k20
#800