request missing address while receiving new last address #748
Conversation
lib/archethic/p2p/message.ex
Outdated
| Contracts.stop_contract(local_last_address) | ||
| end | ||
|
|
||
| process_notify_last_transaction_address(notify_last_tx_address_msg) |
There was a problem hiding this comment.
Why removing the implementation from the message processing as it is used only here ?
There was a problem hiding this comment.
I wanted to be able to unit test this implementation, and to keep the code simple
There was a problem hiding this comment.
I couldn't find test for how the message get processed, do we need to test this or it should be incorporated in a e2e test somewhere else ?
There was a problem hiding this comment.
Send message is mocked, but you can do something like Mocking the message, and in the mock just call Message.process and it will run the process function on the right message
lib/archethic/p2p/message.ex
Outdated
| }) do | ||
| with {local_last_address, _} <- TransactionChain.get_last_address(genesis_address), | ||
| true <- local_last_address != last_address do | ||
| {:ok, tx} = TransactionChain.get_transaction(last_address) |
There was a problem hiding this comment.
If you receive this message, it means that you didn't replicate the last transaction, so using TransactionChain.get_transaction to fetch the transaction from DB will always fail.
I think the previous address has to be added in the message itself, because nodes which sent this message know it
There was a problem hiding this comment.
yes it makes sens, I will do that thank you
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #713
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: