Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scheduler bugs #630

Merged

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Oct 13, 2022

Description

Fixes some bug on network transaction scheduler

  • Add timeout on coingecko request to avoid node to not respond in time for transaction validation 8541abe
  • Fix Process.exit on node detection which was not working with :normal reason 930a0ea
  • Fix reward scheduler when receiving mint reward transaction while in scheduled state, expected behavior is to send node reward transaction after 51a91de
  • Rework handling of node detection process when they exit 680abe8
  • Update summary time and indexes after receiving oracle summary to avoid some cases when node do not pass in the aggregate handler 981f1ab
  • Change date condition to send oracle summary transaction, in some case the polling_date may be greater than the summary_date, but the summary has not been sent. Now whenever the time is greater or equal to summary date, nodes send the summary transaction 981f1ab

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added bug Something isn't working oracle chain Involve OracleChain rewards labels Oct 13, 2022
@samuelmanzanera samuelmanzanera merged commit 5383d26 into archethic-foundation:develop Oct 14, 2022
@Neylix Neylix deleted the Fix-scheduler-bugs branch October 15, 2022 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working oracle chain Involve OracleChain rewards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants