-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework on the dashboard #590
Conversation
default_state() | ||
|> Map.put(:interval, interval) | ||
|> Map.put(:timer, timer) | ||
state = %{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
%{}
|>Map.put(..,..);
|>Map.put(...,...);
??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explicitness is better in my opinion.
Map.put is nice when you want to update a map but to create it, this form seems better.
Can we have complete granfana telemetry ? |
This should be managed separately. |
Description
Fix the dashboard metrics aggregation and plotting.
Fixes #455
Type of change
How Has This Been Tested?
By running transactions the graphs should be updated with up/down lines.
Checklist: