Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve node availability #574

Merged
merged 4 commits into from
Sep 19, 2022
Merged

Improve node availability #574

merged 4 commits into from
Sep 19, 2022

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Sep 15, 2022

Description

Implementation of the new system to calculate the availability of a node based of it's connection time

Fixes #569

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
    (breaking change because the first summary after the update will not work if there is already old version slot in this summary)

How Has This Been Tested?

Tested with test files and some random deconnection / reconnection node

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added bug Something isn't working beacon chain Involve BeaconChain core team Assigned to the core team labels Sep 15, 2022
@Neylix Neylix changed the base branch from master to develop September 15, 2022 13:41
samuelmanzanera
samuelmanzanera approved these changes Sep 19, 2022
View reviewed changes
lib/archethic/beacon_chain/slot_timer.ex
@@ -86,6 +86,11 @@ defmodule Archethic.BeaconChain.SlotTimer do
|> Enum.to_list()
end

def get_time_interval(unit \\ :second) do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to add typespec to the function!

@samuelmanzanera samuelmanzanera merged commit 58e9a6f into archethic-foundation:develop Sep 19, 2022
@samuelmanzanera samuelmanzanera mentioned this pull request Sep 19, 2022
Closed
@Neylix Neylix deleted the Improve-node-availability branch September 23, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelmanzanera samuelmanzanera samuelmanzanera approved these changes

Assignees
No one assigned
Labels
beacon chain Involve BeaconChain bug Something isn't working core team Assigned to the core team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve node availability in beacon slots
2 participants
@Neylix @samuelmanzanera