Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent scheduling network tx #538

Merged
7 commits merged into from
Aug 25, 2022
Merged

Prevent scheduling network tx #538

7 commits merged into from
Aug 25, 2022

Conversation

ghost
Copy link

@ghost ghost commented Aug 23, 2022

Description

This should prevent scheduler to trigger transactions too fastly computed before the scheduling time.
Using FSM we are ensuring to enter in the state of scheduling only when the tx is replicated or after timeouts.

Fixes #420

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ghost ghost added P2P Involve P2P networking bug Something isn't working oracle chain Involve OracleChain shared secrets Involve SharedSecrets rewards labels Aug 23, 2022
@ghost ghost requested a review from Neylix August 23, 2022 21:40
@ghost ghost force-pushed the prevent_scheduling_network_tx branch 2 times, most recently from af50e22 to 5609f92 Compare August 24, 2022 09:15
@ghost ghost force-pushed the prevent_scheduling_network_tx branch from 5609f92 to c90e593 Compare August 24, 2022 22:31
Neylix
Neylix requested changes Aug 25, 2022
View reviewed changes
Copy link
Member

@Neylix Neylix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works well !
Just need to update doctest and it's ok for me

lib/archethic/reward.ex Outdated Show resolved Hide resolved
@ghost ghost merged commit bd3ed98 into develop Aug 25, 2022
@ghost ghost deleted the prevent_scheduling_network_tx branch August 25, 2022 13:06
@ghost ghost mentioned this pull request Aug 25, 2022
Closed
ghost pushed a commit that referenced this pull request Aug 25, 2022
Prevent unexpected scheduling of network tx (#538)
d762fde 
* Add unregister for address notification
* Restrict for node shared secrets tx
* Restrict oracle txs
* Restrict rewards txs
* Add generation of network transaction with specific index
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working oracle chain Involve OracleChain P2P Involve P2P networking rewards shared secrets Involve SharedSecrets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Neylix