Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return fully validated transaction on Transaction Subscriber#456 #489 #489

Merged
1 commit merged into from
Aug 5, 2022
Merged

Conversation

apoorv-2204
Copy link
Contributor

@apoorv-2204 apoorv-2204 commented Aug 3, 2022

Description

  • Include New P2P message to deliver error to client.
  • Include reporting of max nb of confirmations to the client

Fixes # (#456)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Screenshot_20220805_132649
Screenshot_20220805_132844

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@apoorv-2204 apoorv-2204 requested review from imnik11 and a user August 3, 2022 07:11
@apoorv-2204 apoorv-2204 changed the title 456 Return fully validated transaction on Transaction Subscriber#456 #489 Aug 3, 2022
@apoorv-2204 apoorv-2204 marked this pull request as ready for review August 4, 2022 06:40
@apoorv-2204 apoorv-2204 removed the request for review from imnik11 August 5, 2022 08:03
@apoorv-2204 apoorv-2204 added feature New feature request API Involve API facing user labels Aug 5, 2022
@apoorv-2204 apoorv-2204 self-assigned this Aug 5, 2022
lib/archethic_web/transaction_subscriber.ex Outdated Show resolved Hide resolved
lib/archethic_web/transaction_subscriber.ex Outdated Show resolved Hide resolved
@ghost ghost merged commit 92a34db into archethic-foundation:develop Aug 5, 2022
@apoorv-2204 apoorv-2204 deleted the 456 branch August 22, 2022 11:31
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Involve API facing user feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant