Correct self repair notifier #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trigger repair on the right P2P network change
apoorv-2204
reviewed
Aug 2, 2022
|
|
||
| def start_link(args \\ []) do | ||
| GenServer.start_link(__MODULE__, args) | ||
| end | ||
|
|
||
| def init(_) do | ||
| PubSub.register_to_node_update() | ||
| {:ok, []} | ||
| {:ok, %{notified: %{}}} |
There was a problem hiding this comment.
if there is process crash??, and in a situation where all nodes waiting for each other for node_update: message?
There was a problem hiding this comment.
This state is just to avoid multiple node_update message for a given node, to avoid multiple repair in a close time.
There was a problem hiding this comment.
If the process crashes, it will restart with an empty state, and wait another message of unavailability of the node
ghost
pushed a commit
that referenced
this pull request
Aug 17, 2022
Trigger repair on the right P2P network change
Open
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trigger repair on the right P2P network change
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #348
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
When an authorized node is considered as unauthorized or globally offline, this means a topology change occurred, hence the notifier will repair transaction shards but proposing transactions to new storage nodes.
By disconnecting an authorized node the notifier should replicate all the transactions this node was in charge of.
Logs are also added to help to visualize the events.
Checklist: