Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include UCO transfer towards burning address #483

Merged
1 commit merged into from
Aug 2, 2022
Merged

Conversation

ghost
Copy link

@ghost ghost commented Aug 1, 2022

The fee burning has been removed from the transaction movements to remove confusion between manual token burn and the fee burning.

This allows also the display of all the transactions targeting the
burning address as included as input.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #474

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Any fee should be redirected to the burning address as input
As well, we can mention burning address as UCO transfers to burn explicitly more tokens.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

The fee burn have been removed from the transaction movements
and the burn is included as input.

This allows also the display of all the transactions targeting the
burning address.
@ghost ghost requested a review from imnik11 August 1, 2022 22:27
@ghost ghost added bug Something isn't working Fee labels Aug 1, 2022
Copy link
Contributor

@imnik11 imnik11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good, works as expected and if the fee burning is being done explicitly it is working.

@ghost ghost merged commit 35de8cf into develop Aug 2, 2022
@ghost ghost deleted the fix_burn_balances branch August 2, 2022 09:29
ghost pushed a commit that referenced this pull request Aug 17, 2022
The fee burn have been removed from the transaction movements
and the burn is included as input.

This allows also the display of all the transactions targeting the
burning address.
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Fee
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant