Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better p2p concurrency #391

Merged
3 commits merged into from
Jun 24, 2022
Merged

Better p2p concurrency #391

3 commits merged into from
Jun 24, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jun 20, 2022

Description

Improve the P2P concurrency.
Before, back pressure pipelines were spawn for each TCP connection to control concurrency.
Now we want a more global back pressure and concurrency control, hence the pipeline is defined globally.
Also, I increased the nb of workers to avoid blockages when some processes are busy.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ghost ghost changed the base branch from master to develop June 20, 2022 21:09
@ghost ghost added bug Something isn't working P2P Involve P2P networking labels Jun 20, 2022
@ghost ghost self-assigned this Jun 20, 2022
@ghost ghost marked this pull request as ready for review June 21, 2022 16:08
@ghost ghost requested a review from Neylix June 21, 2022 16:08
@Neylix
Copy link
Member

Neylix commented Jun 22, 2022

There is an error when running mix test

@ghost ghost merged commit 8670586 into develop Jun 24, 2022
@ghost ghost deleted the better_p2p_concurrency branch June 24, 2022 12:48
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P2P Involve P2P networking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant