Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integrate miniupnp as C dependency and build locally the binary to use it via system calls.
This way we are reproducing the same behavior.
This is quick fix to do not have to recreate in Erlang or Elixir the UPnP PCP implementation while keeping the support for NAT PMP and UPnP v1/v2
Fixes #346
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested locally using
mix archethic.nettools
on Mac OS X (without upnpc installed)Checklist: