Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate MiniUPNP #375

Merged
4 commits merged into from
Jun 15, 2022
Merged

Integrate MiniUPNP #375

4 commits merged into from
Jun 15, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jun 13, 2022

Description

Integrate miniupnp as C dependency and build locally the binary to use it via system calls.
This way we are reproducing the same behavior.

This is quick fix to do not have to recreate in Erlang or Elixir the UPnP PCP implementation while keeping the support for NAT PMP and UPnP v1/v2

Fixes #346

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested locally using mix archethic.nettools on Mac OS X (without upnpc installed)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ghost ghost added P2P Involve P2P networking feature New feature request labels Jun 13, 2022
@ghost ghost changed the base branch from master to develop June 13, 2022 19:15
@ghost ghost marked this pull request as ready for review June 13, 2022 19:16
@ghost ghost self-assigned this Jun 13, 2022
@ghost ghost requested a review from apoorv-2204 June 13, 2022 20:34
Makefile Show resolved Hide resolved
@apoorv-2204
Copy link
Contributor

apoorv-2204 commented Jun 14, 2022

It is working locally for my pc.

  • image
  • [ ]

@ghost ghost force-pushed the add_miniupnp branch from f274413 to e2e7011 Compare June 14, 2022 06:26
@ghost ghost force-pushed the add_miniupnp branch from e2e7011 to 0e92c88 Compare June 14, 2022 06:27
@ghost ghost force-pushed the add_miniupnp branch from 0e92c88 to fb15f07 Compare June 14, 2022 06:30
@ghost ghost merged commit f3c38f6 into develop Jun 15, 2022
@ghost ghost deleted the add_miniupnp branch June 15, 2022 14:14
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request P2P Involve P2P networking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support PCP for UPnP discovery and port forwarding
1 participant