Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct playbook origin key error #301

Merged
1 commit merged into from
May 4, 2022
Merged

Correct playbook origin key error #301

1 commit merged into from
May 4, 2022

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented May 4, 2022

Description

Correction of a bug in benchmark where the origin private key was still hardcoded and not asked threw the API

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Runned benchmark without error

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added bug Something isn't working shared secrets Involve SharedSecrets testing Improve testing labels May 4, 2022
@Neylix Neylix requested a review from a user May 4, 2022 12:56
@Neylix Neylix changed the base branch from master to develop May 4, 2022 12:57
@ghost ghost merged commit bf62587 into archethic-foundation:develop May 4, 2022
@Neylix Neylix deleted the Correct-playbook-origin-key-error branch May 4, 2022 13:07
ghost pushed a commit that referenced this pull request May 6, 2022
@Neylix
Fix playbook origin key error (#301)
794130f
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
bug Something isn't working shared secrets Involve SharedSecrets testing Improve testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Neylix