Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix beacon summary aggregate #294

Merged
3 commits merged into from
May 2, 2022
Merged

Fix beacon summary aggregate #294

3 commits merged into from
May 2, 2022

Conversation

ghost
Copy link

@ghost ghost commented Apr 29, 2022

Description

This PR fixes the ordering of transaction during synchronization of the missed transactions in the self-repair when a node joins after some time of network liveness.

The issue resolved is not present on docker-compose or local node environment, but only when a node joins after a first one is there for several minutes.

The issue was about the aggregation of beacon summaries

Fixes #287

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Start a node using iex -S mix
  • After several 5/10 min, start another using: ARCHETHIC_P2P_PORT=3005 ARCHETHIC_HTTP_PORT=4005 ARCHETHIC_CRYPTO_SEED="node2" iex -S mix
  • The transaction should be synchronized without the :invalid_proof_of_election error

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ghost ghost added bug Something isn't working self repair Involve SelfRepair mechanism labels Apr 29, 2022
@ghost ghost requested a review from Neylix April 29, 2022 15:50
@ghost ghost merged commit ee386cc into develop May 2, 2022
@ghost ghost deleted the fix_beacon_summary_aggregate branch May 2, 2022 07:32
ghost pushed a commit that referenced this pull request May 6, 2022
* Improve next summary date for Beacon summary time
* Fix ordering of transactions in self repair
* Fix clean db task output with multiple local nodes
@samuelmanzanera samuelmanzanera mentioned this pull request May 30, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working self repair Involve SelfRepair mechanism
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant