Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NFT tx movement decoding #283

Merged
1 commit merged into from
Apr 19, 2022
Merged

Fix NFT tx movement decoding #283

1 commit merged into from
Apr 19, 2022

Conversation

ghost
Copy link

@ghost ghost commented Apr 19, 2022

Description

This PR fixes the transaction movement issue from the to_map decoding of the NFT cases.

Fixes #281

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Create an address and allocate funds through the faucet
  • Create a transaction chain with NFT, with allocated funds
  • Create another address for a recipient
  • Create a transaction to transfer the NFT
  • Go to the explorer, it should not reproduce the error of decoding

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ghost ghost added the bug Something isn't working label Apr 19, 2022
@ghost ghost self-assigned this Apr 19, 2022
@ghost ghost requested a review from Neylix April 19, 2022 09:37
@ghost ghost added the transaction Involve transactions label Apr 19, 2022
@ghost ghost merged commit 6c23d15 into develop Apr 19, 2022
@ghost ghost deleted the fix_nft_field_decoding branch April 19, 2022 10:13
@ghost ghost mentioned this pull request Apr 27, 2022
ghost pushed a commit that referenced this pull request May 6, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working transaction Involve transactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant