Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete burn of the transaction fee #259

Merged
3 commits merged into from
Mar 15, 2022
Merged

Complete burn of the transaction fee #259

3 commits merged into from
Mar 15, 2022

Conversation

ghost
Copy link

@ghost ghost commented Mar 14, 2022 •
edited by blackode
Loading

Description

This feature provides removal of node_movements in the transaction validation stamp and also complete burn of the transaction's fee, so the node rewards will not be replicated during the transaction validation.

Fixes #163 #124

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Check on the transaction explorer to not see any node movements
  • Check on the explorer, the node doesn't get reward inputs after tx validation

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ghost ghost force-pushed the burn_fee branch from fc14d4c to be6f67e Compare March 14, 2022 23:38
@ghost ghost self-assigned this Mar 14, 2022
@ghost ghost requested a review from blackode March 14, 2022 23:45
@ghost ghost assigned blackode Mar 14, 2022
blackode
blackode approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@blackode blackode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Read PR description

  • Read AC

  • Pulled branch, manually tested, verified AC are met

  • mix test

  • Check on the transaction explorer to not see any node movements

  • Check on the explorer, the node doesn't get reward inputs after tx validation

  • Reviewed the code

@ghost ghost assigned blackode and unassigned blackode Mar 15, 2022
@ghost ghost changed the title Burn complete transaction fee Complete burn of the transaction fee Mar 15, 2022
@ghost ghost merged commit ff969e9 into develop Mar 15, 2022
@ghost ghost deleted the burn_fee branch March 15, 2022 09:54
ghost pushed a commit that referenced this pull request Mar 24, 2022
Complete burn of the transaction fee (#259)
0f8501d 
* Remove node_movements

* Remove reward flag from an unspent output

* Add transaction's in the beacon chain
@ghost ghost mentioned this pull request Apr 27, 2022
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@blackode blackode

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@blackode