Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timeout issue in subset making genserver crash + refactor #1654

Merged
merged 4 commits into from
Feb 3, 2025

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Feb 1, 2025

Description

  • Removed useless p2p view request while adding new attestation in subset
  • Refactor p2p view creation
  • Create slot and summary inside async Task to not block the subset Genserver
  • Also fixes an old issue to send beacon slot even if not beacon slot node

Fixes #981

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added bug Something isn't working beacon chain Involve BeaconChain labels Feb 1, 2025
@Neylix Neylix merged commit 8a7d4ac into archethic-foundation:develop Feb 3, 2025
1 of 2 checks passed
@Neylix Neylix deleted the Fix-subset branch February 3, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beacon chain Involve BeaconChain bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send beacon slot if there is at least 1 replication attestation
1 participant