Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore asdf upstate exit code #1636

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Jan 14, 2025

Description

Since last version of asdf, the command asdf update is deprecated and return an exit code 1 which stop the install.sh script
I just ignored the exit code so the script don't stop

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added bug Something isn't working dependencies Pull requests that update a dependency file system Involve system management labels Jan 14, 2025
@Neylix Neylix merged commit aafff5a into archethic-foundation:develop Jan 14, 2025
1 of 2 checks passed
@Neylix Neylix deleted the Fix-asdf-update branch January 14, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file system Involve system management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant