Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor quorum to run acceptance resolver once #1602

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Nov 19, 2024

Description

Refactor P2P.quorum to avoid executing acceptance resolver multiple time

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added the quality Improve code quality label Nov 19, 2024
@Neylix Neylix merged commit b570e22 into archethic-foundation:develop Nov 20, 2024
1 of 2 checks passed
@Neylix Neylix deleted the refactor-quorum branch November 20, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality Improve code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants