Consume the MUCO correctly #1593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6bd3ed4 to
89b541d
Compare
Neylix
requested changes
Nov 7, 2024
Ensure validate_sufficient_funds add movements to the struct
It allow to ensure the order of called functions
wassimans
pushed a commit
to wassimans/archethic-node
that referenced
this pull request
Nov 13, 2024
* consume the MUCO correctly * lint: use factory * update order in the tests * movements passed by the validate_sufficient_funds func * Add test to ledger_validation_test Ensure validate_sufficient_funds add movements to the struct * Add state field in LedgerValidation struct It allow to ensure the order of called functions * Simplify MUCO test --------- Co-authored-by: Neylix <julien.leclerc05@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A bug was introduced in 1.5.11's refactor where the UCO were consumed instead of the MUCO. This is an incorrect behaviour and people with MUCO were consuming UCO instead of MUCO when transferring MUCO.
This fix the issue by resolving MUCO only after the consume step.
Type of change
How Has This Been Tested?
Added a unit test
Checklist: