Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a timer:interval for heartbeats and avoid concurrent connections attempts #1592

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

bchamagne
Copy link
Contributor

@bchamagne bchamagne commented Nov 7, 2024

Description

Avoid snowballs of heartbeats in case of reconnect spams.
Add a connecting state to avoid attempting multiple concurrent connect

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

manual tests with 2 nodes

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bchamagne bchamagne added the bug Something isn't working label Nov 7, 2024
@bchamagne bchamagne changed the title Use a timer:interval for heartbeats Use a timer:interval for heartbeats and avoid concurrent connections attempts Nov 12, 2024
@Neylix Neylix force-pushed the heartbeats-interval branch from 6d5ff38 to 6154478 Compare November 12, 2024 14:21
@Neylix Neylix merged commit f6f65ab into archethic-foundation:develop Nov 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants