Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some repair messages in the TransactionChain #1587

Merged
merged 5 commits into from
Jan 15, 2025
Merged

Add some repair messages in the TransactionChain #1587

merged 5 commits into from
Jan 15, 2025

Conversation

bchamagne
Copy link
Contributor

@bchamagne bchamagne commented Oct 30, 2024 •
edited
Loading

Description

It's often possible to trigger some repair when looking at the quorum results.
This PR will stay in draft until #1562 #1588 is done.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

unit tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bchamagne bchamagne added the P2P Involve P2P networking label Oct 30, 2024
@bchamagne bchamagne marked this pull request as draft October 30, 2024 13:19
@Neylix Neylix marked this pull request as ready for review November 19, 2024 11:04
@Neylix Neylix force-pushed the repair-messages-2 branch 2 times, most recently from 240f3cc to f8722a5 Compare November 29, 2024 15:54
@Neylix Neylix changed the base branch from develop to 1.7.0 January 9, 2025 16:17
@Neylix Neylix force-pushed the repair-messages-2 branch from f8722a5 to 8aefded Compare January 9, 2025 16:25
@Neylix Neylix added self repair Involve SelfRepair mechanism enhancements labels Jan 15, 2025
@Neylix Neylix merged commit dcce83e into archethic-foundation:1.7.0 Jan 15, 2025
1 check passed
Neylix pushed a commit that referenced this pull request Feb 5, 2025
@Neylix
Add some repair messages in the TransactionChain (#1587)
a003341 
* transaction_exists_globally? repair function

* fetch_genesis_address repair function

* fetch_last_address repair function

* fetch_transaction repair_fun

* fetch repair_fun
Neylix pushed a commit that referenced this pull request Feb 11, 2025
@Neylix
Add some repair messages in the TransactionChain (#1587)
21143eb 
* transaction_exists_globally? repair function

* fetch_genesis_address repair function

* fetch_last_address repair function

* fetch_transaction repair_fun

* fetch repair_fun
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancements P2P Involve P2P networking self repair Involve SelfRepair mechanism
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bchamagne @Neylix