Filter p2p view size on during aggregation of summaries #1573
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In some case this is possible that a node start it's self repair but as missed a new node transaction and so doesn't know this node.
Before starting the synchronize the missed transactions, the node aggregate the P2P view and ensure the p2p view of each summary has the same size of the expected node to sample for the summary subset. But since don't know all the node, the size comparison will fail and will make the p2p view empty
To fix this, instead of ensuring the p2p view size with local data, during aggregation the node will take the most frequent size across all summaries.
Type of change
How Has This Been Tested?
Starts 3 nodes at the same time, after the first summary, the 3rd node will have a wrong p2p view compared to others
Checklist: