Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Elixir Version module on migrate version compare #1568

Merged

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Oct 8, 2024

Description

Fixes an issue where a version is for example "1.5.10" and a migration task is created for version "1.5.9".
The Migrate module compare version as string and 1.5.9 > 1.5.10 while it should not be.
Used the Elixir Version module to fix it

Type of change

  • Bug fix (non-breaking change which fixes an issue)

On current version (1.5.10) run a node, stop it and restart it, without the fix it will try to run the migration for 1.5.9 that fail.
It does not run the migration after the fix

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added bug Something isn't working release Involve release / hot reload mecanism labels Oct 8, 2024
@Neylix Neylix changed the title Use Version module on migrate version compare Use Elixir Version module on migrate version compare Oct 8, 2024
@samuelmanzanera samuelmanzanera added this to the 1.5.11 milestone Oct 8, 2024
@Neylix Neylix merged commit 4062b4d into archethic-foundation:develop Oct 8, 2024
2 checks passed
@Neylix Neylix deleted the Fix-migrate-version-compare branch October 8, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working release Involve release / hot reload mecanism
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants