Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor GetUnspentOutput message #1462

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Mar 14, 2024

Description

Add new chain_sync_date field for conflict resolver and update offset mechanism

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Running playbook as it also use graphql query chainUnspentOuputs

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added serialization Involve message serialization API Involve API facing user enhancements labels Mar 14, 2024
@Neylix Neylix requested a review from samuelmanzanera March 14, 2024 12:17
@Neylix Neylix force-pushed the Fix-GetUnspentOuput branch 4 times, most recently from a9d0ce1 to 0dc9a2f Compare March 14, 2024 12:31
Add new chain_sync_date field for conflict resolver and update offset
@Neylix Neylix force-pushed the Fix-GetUnspentOuput branch from 0dc9a2f to 7f907ed Compare March 14, 2024 12:42
@Neylix Neylix merged commit 7b8def4 into archethic-foundation:develop Mar 15, 2024
1 check failed
@Neylix Neylix deleted the Fix-GetUnspentOuput branch March 15, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Involve API facing user enhancements serialization Involve message serialization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant