Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the same timeout on all tasks related to network patches #1376

Merged

Conversation

bchamagne
Copy link
Contributor

Description

The network patch calculation takes up to 15seconds in testnet. The timeout values were too low.
This PR calculate the timeout based on the next SelfRepair tick.

In practice, we're setting the timeout to 4m30s instead of 5s.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

locally with 3 nodes

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bchamagne bchamagne added bug Something isn't working beacon chain Involve BeaconChain labels Jan 12, 2024
@bchamagne bchamagne added this to the 1.4.5 milestone Jan 16, 2024
@samuelmanzanera samuelmanzanera merged commit 5c247d8 into archethic-foundation:develop Jan 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beacon chain Involve BeaconChain bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants