Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Merging utxos updates the timestamp #1319

Conversation

bchamagne
Copy link
Contributor

Description

There is a bug on 1.3.0 when merging multiple same utxos together. This was not updating the timestamp and depending on the order of the inputs list, different nodes get differents utxos resulting in a consensus issue. Which mean some transaction cannot be validated even though they are valid.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Unit tested

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bchamagne bchamagne added the bug Something isn't working label Nov 9, 2023
@bchamagne bchamagne requested a review from Neylix November 9, 2023 10:51
@bchamagne bchamagne added this to the 1.3.1 milestone Nov 9, 2023
@Neylix Neylix merged commit 17049c1 into archethic-foundation:release/1.3.1 Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants