-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recipients arguments encoding #1304
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
91a28dc
to
e8500ed
Compare
Neylix
reviewed
Oct 17, 2023
lib/archethic/transaction_chain/transaction/data/recipient/arguments_encoding.ex
Show resolved
Hide resolved
test/archethic/transaction_chain/transaction_data/recipients/arguments_encoding_test.exs
Show resolved
Hide resolved
0c6740c
to
1545c8d
Compare
bchamagne
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested while developing the new version of the JS SDK.
I was able to trigger contracts with named action.
Neylix
approved these changes
Oct 17, 2023
cb1dde4
to
a717e61
Compare
👍 |
a717e61
to
22deef0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
serialization
Involve message serialization
transaction
Involve transactions
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to resolve an issue of inconsistency with JSON encoding, particularly with decimals.
Hence, it introduces a typed encoding approach of arguments and also use a different algorithm for the previous signature verification and the storage.
Previous signature tx's serialization happens with bit encoded on 1 byte (to simplify SDK and client integration), while for storage we can encode into 1 bit (Erlang allow us to optimize bitstring encoding easily)
Type of change
Checklist: