Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipient fees calculation on estimate transaction fee #1295

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Oct 10, 2023

Description

Since this PR #1288, users have to pay fees for the smart contract they trigger in the recipients. This fee calculation was not added to the estimate transaction fee API.

This PR fixes it by adding the same behavior in the estimation than in the validation context

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested manually with JSON RPC request

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added bug Something isn't working API Involve API facing user Fee labels Oct 10, 2023
@Neylix Neylix added this to the 1.3.1 milestone Oct 10, 2023
@Neylix Neylix merged commit e52c04e into archethic-foundation:release/1.3.1 Oct 10, 2023
@Neylix Neylix deleted the recipient-fees branch October 10, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Involve API facing user bug Something isn't working Fee
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants