-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor contract ownerships #1269
Merged
Neylix
merged 8 commits into
archethic-foundation:develop
from
Neylix:Refactor-contract-ownerships
Sep 14, 2023
Merged
Refactor contract ownerships #1269
Neylix
merged 8 commits into
archethic-foundation:develop
from
Neylix:Refactor-contract-ownerships
Sep 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9f6113b
to
0a3ff9e
Compare
samuelmanzanera
approved these changes
Sep 12, 2023
|
0a3ff9e
to
2244392
Compare
2244392
to
1bd5911
Compare
bchamagne
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it with playground
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
Identify a change with a breaking API
feature
New feature request
quality
Improve code quality
smart contracts
Involve smart contracts
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improve the usability of the ownerships in the smart contracts. It also do some refactor about the contract constants.
contract
(removing it before creating the constant)Ownership
module, used incontract.ownership
variable.secrets
,secret_keys
andauthorized_public_keys
does not exist anymoreContract.add_ownership
has a new api withsecret
andauthorized_keys
as a map of public_key => encrypted_keyContract.add_ownership
keeps the order specified by the contract codeTransactionFactory
as the constants are now more strict (cannot have a nil address for example)Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Units tests
Manual testing by creating contract and using ownerships
Checklist: