Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor named action to use arity as key #1235

Merged

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Aug 29, 2023

Description

Fixes an issue where condition code was not found if the name of args in a named condition are not the same as the one in the named action

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Unit test + manuel testing

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added bug Something isn't working smart contracts Involve smart contracts labels Aug 29, 2023
@Neylix Neylix merged commit a57e72b into archethic-foundation:develop Aug 31, 2023
@Neylix Neylix deleted the fix-named-action-args-names branch August 31, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working smart contracts Involve smart contracts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants