Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON RPC methods that used transaction as payload now only takes 1 param #1226

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

bchamagne
Copy link
Contributor

@bchamagne bchamagne commented Aug 22, 2023

Description

Wrap the transaction payload inside a "transaction" object for these 3 methods: SimulateContractExecution, EstimateTransactionFee and SendTransaction.

Fixes #1225

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

This require the 3 SDKs to be updated.

  • libgo
  • libdart
  • libjs

How Has This Been Tested?

Unit tested

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix merged commit aadb978 into archethic-foundation:develop Aug 24, 2023
@Neylix Neylix added enhancements and removed breaking change Identify a change with a breaking API labels Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Involve API facing user enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JsonRPC params to be similar to Open RPC
2 participants