Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps and remove babel #1222

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Aug 18, 2023

Description

Update dependencies and remove babel.
Babel was used with webpack while we now use esbuild

How Has This Been Tested?

Tested explorer after deletion, it still works as expected

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

babel was used with webpack while we now use esbuild
@Neylix Neylix added the dependencies Pull requests that update a dependency file label Aug 18, 2023
@Neylix Neylix requested a review from bchamagne August 18, 2023 07:35
Copy link
Contributor

@bchamagne bchamagne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cloned the repo, did the 3 commands to start a node, and everything works as expected.

@Neylix Neylix merged commit 774e743 into archethic-foundation:develop Aug 22, 2023
@Neylix Neylix deleted the update-nodejs-deps branch August 22, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants