-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AEIP-19 token recipients #1214
Merged
Neylix
merged 16 commits into
archethic-foundation:1174-token-resupply
from
bchamagne:1175-token-mint-and-send
Aug 22, 2023
Merged
AEIP-19 token recipients #1214
Neylix
merged 16 commits into
archethic-foundation:1174-token-resupply
from
bchamagne:1175-token-mint-and-send
Aug 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2566253
to
e844e0f
Compare
Neylix
requested changes
Aug 8, 2023
1f5c683
to
6a5b41e
Compare
Neylix
approved these changes
Aug 22, 2023
Neylix
added a commit
that referenced
this pull request
Aug 30, 2023
* add recipients to token creation schema * add recipients to resupply schema * verify token recipients address & amount * wip - inconsisentencies tx movment * wip - error insufficient funds * wip * refactor consume_inputs * lint: add ledgerops.tokens_to_mint * unit test ledger operations * unit test transaction.get_movements/1 * add more unit tests * credo * Fetch in parallel * lint after feedback * Fees take token recipients into account * Lint + add token_id verification --------- Co-authored-by: Neylix <julien.leclerc05@protonmail.com>
Neylix
added a commit
that referenced
this pull request
Aug 30, 2023
* add recipients to token creation schema * add recipients to resupply schema * verify token recipients address & amount * wip - inconsisentencies tx movment * wip - error insufficient funds * wip * refactor consume_inputs * lint: add ledgerops.tokens_to_mint * unit test ledger operations * unit test transaction.get_movements/1 * add more unit tests * credo * Fetch in parallel * lint after feedback * Fees take token recipients into account * Lint + add token_id verification --------- Co-authored-by: Neylix <julien.leclerc05@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
/!\ Base branch 1174-token-resupply (AEIP-18)
This is AEIP-19 implementation. This adds a
recipients
field in the token transactions. Minted tokens can be sent to recipients in the same transaction.Fixes #1175
Type of change
How Has This Been Tested?
Scenario 1: Create a token with recipients
Scenario 2:
Many unit tests
Checklist: