Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scope refactor #1199

Merged
merged 8 commits into from
Jul 31, 2023
Merged

Scope refactor #1199

merged 8 commits into from
Jul 31, 2023

Conversation

herissondev
Copy link
Contributor

Description

This pr refactores the Scope module so that the scope is entirely handled by it.

Fixes # (issue)

Type of change

non-breaking change

How Has This Been Tested?

New tests for the scope module have been added

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@herissondev herissondev requested review from Neylix and bchamagne July 27, 2023 15:33
Neylix
Neylix requested changes Jul 28, 2023
View reviewed changes
lib/archethic/contracts/interpreter/scope.ex Outdated Show resolved Hide resolved
lib/archethic/contracts/interpreter/scope.ex Show resolved Hide resolved
lib/archethic/contracts/interpreter/scope.ex Outdated Show resolved Hide resolved
lib/archethic/contracts/interpreter/scope.ex Outdated Show resolved Hide resolved
test/archethic/contracts/interpreter/scope_test.exs Outdated Show resolved Hide resolved
test/archethic/contracts/interpreter/scope_test.exs Outdated Show resolved Hide resolved
test/archethic/contracts/interpreter/scope_test.exs Outdated Show resolved Hide resolved
test/archethic/contracts/interpreter/scope_test.exs Show resolved Hide resolved
test/archethic/contracts/interpreter/scope_test.exs Show resolved Hide resolved
test/archethic/contracts/interpreter/scope_test.exs Outdated Show resolved Hide resolved
@Neylix Neylix changed the base branch from develop to fee_sc July 28, 2023 15:01
@Neylix Neylix changed the base branch from fee_sc to develop July 28, 2023 15:01
@Neylix Neylix merged commit 7efafb6 into develop Jul 31, 2023
@Neylix Neylix deleted the scope_refactor branch July 31, 2023 10:02
Neylix pushed a commit to Neylix/archethic-node that referenced this pull request Aug 1, 2023
@herissondev @Neylix
Scope refactor (archethic-foundation#1199)
e4d80eb 
* scope implement context

* test scope

* implement scope refactor

* fix leave_scope

* fix create

* fix leave_context

* fix tests

* make init private
@Neylix Neylix mentioned this pull request Aug 10, 2023
Closed
2 tasks
@samuelmanzanera samuelmanzanera mentioned this pull request Feb 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neylix Neylix Neylix approved these changes

@bchamagne bchamagne bchamagne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@herissondev @Neylix @bchamagne